Message when hurting monsters with elemental damage
issueid=1888 01-29-2013 09:43 PM
Senior Member
Number of reported issues by aerol: 70
Message when hurting monsters with elemental damage
About the message displayed when hurting monsters with elements they're vulnerable to

When hurting monsters in melee, with missiles or with spells, ADOM displays the message "the foo is slightly/moderately/etc injured" if it's a living being and "slightly/moderately/etc damaged" if it's an undead, construct, etcetera. Also, in 1.1.1, when a monster was hurt by elemental damage it was vulnerable to, the message displayed would be "the red dragon is badly injured by the ice blast!" or "the steel golem is badly injured by the crackling lightning bolts!". So "badly injured" was displayed for both monster types.

Because of this inconsistency in 1.1.1, somewhere in the prereleases (I believe it was in p1) these later messages were changed to "the red dragon is painfully injured by the ice blast" and "the steel golem is very effectively damaged by the crackling lightning bolts".

Even though these new messages are not technically grammatically incorrect, it's my opinion, shared by others I've talked to, that they don't sound quite right in English. They sound wooden, clunky, and not quite right.

So, I suggest changing the messages to "badly injured" in the case of a living being and "badly damaged" in the case of an undead/construct/etc. This would be consistent, sound good in English, and convey the important extra information: namely, that the monster is vulnerable to the element that just hurt it.

Edit: reworded for clarity and corrected innacuracies
Issue Details
Issue Number 1888
Project ADOM (Ancient Domains Of Mystery)
Category All
Status Fixed
Priority Unknown
Affected Version ADOM 1.2.0 pre 10
Fixed Version ADOM 1.2.0 pre 12
Milestone (none)
Users able to reproduce bug 0
Users unable to reproduce bug 0
Assigned Users (none)
Tags (none)




01-29-2013 10:17 PM
Ancient Member
Well, constructs and undead aren't alive, so "badly injured" would be incorrect for them (which is why this was changed in the first place).

Perhaps use the old message for living beings, and change it to "is greatly/highly damaged" for the others?

01-30-2013 02:06 AM
Senior Member
If I recall correctly it was "badly injured" for living beings and "badly damaged" for constructs and undead - which is perfectly good as far as I see it.

01-30-2013 02:24 AM
Ancient Member
Just checked it in 1.1.1, and steel golems hit by lightning balls were "badly injured" by the crackling bolts.

01-30-2013 02:29 AM
Senior Member
Ah. In that case, restoring "badly injured" for living beings and changing it to "badly damaged" for others seems like a good solution.

02-19-2013 07:15 PM
jt jt is offline
Administrator
Fixed. The routine that displays the correct "monster wound status" is called, so the amount of damage caused by the attack is now accurate. So now the same messages are show as in the other places.

02-19-2013 08:22 PM
Senior Member
Jt: even though your fix would display a more accurate wound status, it would obscure the extra information conveyed by the different messages: that is, that the monster is especially vulnerable to the element that just hurt it. In my opinion that extra information is more important than the exact wound status (which is why the separate messages were implemented in the first place). I've reworded the original issue text; please consider my proposal instead. Thanks!

02-19-2013 09:10 PM
jt jt is offline
Administrator
@aerol: I see your point, "badly" was some kind of keyword to notice the special vulnerabilty. So I've changed the message back to the way it was in 1.1.1 (except for the distinction of "damaged" and "injured"). The PC only notices the vulnerability if at least one point of damage was caused by the attack (this is different too).

+ Reply