Selecting option from menu opened with F8 or F9 does not stop key event
issueid=3267 08-02-2014 10:55 PM
Ancient Member
Number of reported issues by Sami: 91
Selecting option from menu opened with F8 or F9 does not stop key event

Selecting option from graphics menu or adom-specific options does not stop key event from propagating to the game if those menus are opened with F8 or F9.

I suppose following fix should work:
Code:
diff -r -u3 r50_noteye_orig/games/adom-utils.noe r50_noteye/games/adom-utils.noe
--- r50_noteye_orig/games/adom-utils.noe        2014-08-01 11:47:40.000000000 +0300
+++ r50_noteye/games/adom-utils.noe     2014-08-03 00:31:18.697658261 +0300
@@ -550,10 +550,12 @@

   if iskey(ev, KEYS.F8) and ev.type == evKeyDown then
     menuexecute(modesmenu, dfthdr("Select your graphical mode:"))
+    textconsumed = true
     return true

   elseif iskey(ev, KEYS.F9) and ev.type == evKeyDown then
     menuexecute(adommenu, adomhdr)
+    textconsumed = true
     return true

   elseif iskey(ev, KEYS.F10) and ev.type == evKeyDown then
or alternatively this one (add textconsumed = true at the end of menuexecute function and remove same line from handlespecialkeys function because textconsumed is already set to true in menuexecute):
Code:
diff -r -u3 r50_noteye_orig/common/keymap.noe r50_noteye/common/keymap.noe
--- r50_noteye_orig/common/keymap.noe   2014-08-01 11:47:40.000000000 +0300
+++ r50_noteye/common/keymap.noe        2014-08-03 00:34:57.455886264 +0300
@@ -654,7 +654,6 @@
       end
     noteyemenu()
     drawandrefresh()
-    textconsumed = true
     return true
 
   elseif ev.type == evKeyDown and iskey(ev, KEYS.F2) and quickshots then
diff -r -u3 r50_noteye_orig/common/menu.noe r50_noteye/common/menu.noe
--- r50_noteye_orig/common/menu.noe     2014-08-01 11:47:40.000000000 +0300
+++ r50_noteye/common/menu.noe  2014-08-03 00:35:02.327925341 +0300
@@ -188,6 +188,7 @@
       end
     end
   clrscr()
+  textconsumed = true
   end
 
 -- == ask for string, and applymod ==
Issue Details
Issue Number 3267
Project ADOM (Ancient Domains Of Mystery)
Category All with NotEye
Status Fixed
Priority 8
Affected Version ADOM r50
Fixed Version ADOM r51
Milestone (none)
Users able to reproduce bug 0
Users unable to reproduce bug 0
Assigned Users Zeno
Tags (none)




08-16-2014 10:27 AM
Ancient Member
Should be fixed for R51.

+ Reply