Choosing the skilled talent crashes the game.
issueid=9 03-07-2008 09:35 PM
Junior Member
Number of reported issues by Dental_floss: 5
Choosing the skilled talent crashes the game.
Choosing the skilled talent crashes the game.

Any character or class selecting any "skill" talent will immediately crash the game. This bug affects all versions that include the skilled set of talents.
Issue Details
Issue Number 9
Project ADOM (Ancient Domains Of Mystery)
Category Windows XP
Status Fixed
Priority 2
Affected Version ADOM 1.1.1
Fixed Version ADOM 1.2.0 pre 1
Users able to reproduce bug 12
Users unable to reproduce bug 0
Assigned Users (none)
Tags (none)




03-09-2008 12:20 PM
jt jt is offline
Administrator
I can confirm this problem. Here are some details for Thomas to fix this bug:

I think the problem is, that the "skilled" talent is handled twice. First in talents.c (ModifyByTalent(), lines 561-577) and a second time in init.c (InitializeGame(), lines 1664-1681).

Each routine calls ModifySkillBy() with different values for the parameter "no_magic", which leads to an "Illegal skill advancement" error, when the this function is called from init.c (no_magic = TRUE).

12-20-2008 02:31 AM
Junior Member
It always has, ever since it was introduced.. TB claimed he fixed it from v1.1.0 to 1.1.1 but that wasn't accurate, as it still occurred.

Perhaps in the 1.2.x versions this will finally be addressed, but I think (just from inferences) that TB is working hard on JADE so might not tackle ADOM problems right now.

02-04-2009 01:26 AM
Junior Member
Who would ever take skilled anyway? =)

03-11-2009 02:39 AM
Ancient Member
Quote Originally Posted by Krough Firender
Who would ever take skilled anyway? =)
I agree. It's a waste of a talent. If it gave you some extra(2-3) skills, maybe, but +2 to each skill? That's nothing.

04-28-2010 10:39 PM
Senior Member
According to sorear, "Skill increases come in two flavors, ones that also increase potential and ones that don't; Skilled uses the wrong type and the game asserts after potential goes negative. "

02-01-2012 06:59 PM
jt jt is offline
Administrator
ModifySkillBy() is now called with "no_magic=FALSE".

02-13-2012 01:54 AM
Ancient Member
According the r.g.r.a bug list, the -foo- Skilled talents also do twice what it says in the manual - is that also fixed?

02-13-2012 06:22 PM
jt jt is offline
Administrator
I could not reproduce this problem. The values in the manual and source code match, you gain "+2" for selecting "Skilled" and "+3" for selecting "Very skilled".

+ Reply