Abusable overflow when entering the character name on MS-DOS
issueid=1122 07-11-2012 06:15 PM
jt jt is online now
Administrator
Number of reported issues by jt: 45
Abusable overflow when entering the character name on MS-DOS

The forum thread explains it in detail:

http://www.adom.de/forums/showthread...this-will-have

"Yes, it is definately a buffer overflow problem since it writes the last bytes of the name over the race pointer which comes immediately after the name. I had tried using several different characters as the final character but could only get Human. If your final character is a space, ADOM simply drops it and treats your name as one character shorter. I had tried to input lower non-printing values and even some Unicode characters but those also seemed to get dropped from the name and had no effect."
Issue Details
Issue Number 1122
Project ADOM (Ancient Domains Of Mystery)
Category Unknown
Status Fixed
Priority Unknown
Affected Version Unknown
Fixed Version ADOM 1.2.0 pre 3
Users able to reproduce bug 0
Users unable to reproduce bug 0
Assigned Users (none)
Tags (none)




07-11-2012 06:16 PM
jt jt is online now
Administrator
Fixed.

08-05-2012 12:56 PM
Ancient Member
I could reproduce this in 1.2.0 prerelease 1. I pressed the plus sign (on the numpad) instead of Ctrl+Delete, and managed to crash the game by entering a too long name.

(Douple posted this, previous version was private by accident. Can someone delete that?)

08-05-2012 04:39 PM
jt jt is online now
Administrator
I was pretty sure that I fixed this bug (couldn't really test it in my Windows XP VM because I could not get the key combination to work). Just now I detected that the routine I fixed wasn't even called from the MS-DOS version, even though the "ifdefs" pointed to it. Oh well...

+ Reply