Wand/Slamander signs not working as expected.
issueid=3014 05-27-2014 04:33 PM
Ancient Member
Number of reported issues by Soirana: 41
Wand/Slamander signs not working as expected.
Well, from in game description one would expect mentioned signs give permanent percentage boost [20% always/10% for neutral starts].
However from my experience with save editors in adom 1.1.1 it appears not to be the case.
For clean experiment I run couple wizzards [p23 server] through some minor leveling [one candle born/one salamander] - well, they did not start withe equal wi/mana stats, bot ended with training mana to make parity. No spellcaster corpses eaten or wands being drained.
Final results:
Candle level 10 --15 Willpower/14 Mana -- 87PP
Salamander level 10 --15 Willpower/14 Mana -- 73PP.

I guess there is some variance/unknown factors involved, but salamander if assumed 20% bonus is in would be 60PP natural, which is extremely low for level 10 in my experience - that also would be less than 70% of candle wizzard PP.

Save files can be found at http://ancardia.uk.to/adom_users/soi...120p23/savedg/
Candlebo.svg and Salamnde.svg.

Could we get either manual description or PP accumulation formula to be changed?
Issue Details
Issue Number 3014
Issue Type Bug
Project ADOM (Ancient Domains Of Mystery)
Category All
Status Fixed
Priority 7
Affected Version ADOM 1.2.0 pre 23
Fixed Version ADOM r56
Milestone Initial Steam Release
Users able to reproduce bug 2
Users unable to reproduce bug 0
Attachments 1
Assigned Users adom-admin
Tags (none)




07-06-2014 02:51 PM
The Creator
I guess you are falling for some observation error (maybe due to the nature of the RNG). Salamander definitely gets you a 20% boost. The code is very simple and clear:

void ModifyPCMaxPower(int value)
{
if (GetStarSign(pc.birthday) == SS_SALAMANDER && value > 0)
value += (value / 5);
...
}
Reply Reply  

07-06-2014 05:02 PM
Ancient Member
Quote Originally Posted by adom-admin
I guess you are falling for some observation error (maybe due to the nature of the RNG). Salamander definitely gets you a 20% boost. The code is very simple and clear:

void ModifyPCMaxPower(int value)
{
if (GetStarSign(pc.birthday) == SS_SALAMANDER && value > 0)
value += (value / 5);
...
}
The parameter "value" gets multiplied by 1.2 but that snippet doesn't show it being assigned to anywhere outside the method (the parameter seems to be a copy of the passed value, not a reference or pointer).
Also if that function is called many times with small values (like individually at every level up) then any value < 5 will not increase max PP at all due to integer truncation.
Reply Reply  

01-15-2015 05:43 PM
Ancient Member
Okay, maybe sample was undermined due to randomness on PP received per level up.

Experiment 2:
2 dwarven wizards -- both wi15, mana 20 [mana fixed via equipment], one salamander born, one candle at xp lv6 uses exploration mode wand to wish for boost mana potions to get temporal mana of 59 [waited for boost slightly to decline to synchro.]
Candle before boost 69PP, after 114 [+45]
Salamander before 62PP, after 107 [+45]

Both bonuses checked twice same differential, does not match expected 20%. [Saves for willing to check attached in zip].

I guess it is cute that code is "simple and clear", but people in general expect end effect being same as of power armor --- 20% tot total PP which is clearly not the result. In general various testing shows that PP received via Mana/Wilpower x levelups never get Salamander bonus.
Reply Reply  

01-16-2015 03:34 PM
Senior Member
It gets rounded down A LOT. So the real actual increase is about half of the stated effect.
Reply Reply  

01-25-2015 02:26 PM
The Creator
Fixed.
Reply Reply  

+ Reply