Incorrect Syntax with zero monster kills during game
issueid=6303 09-09-2018 04:24 PM
Junior Member
Number of reported issues by djbrianuk: 1
Incorrect Syntax with zero monster kills during game
says "you did not manage to vanquish any monsters" using :k command during play.

Very simple. Using :k before getting any kills displays "you did not manage to vanquish any monsters" which is in the incorrect past tense. Should be ""you have not yet managed to vanquish any monsters"
Issue Details
Issue Number 6303
Project ADOM (Ancient Domains Of Mystery)
Category Windows 10 (NotEye)
Status Unconfirmed
Priority 10 - Lowest
Affected Version ADOM 3.0.6
Fixed Version (none)
Milestone (none)
Users able to reproduce bug 0
Users unable to reproduce bug 2
Assigned Users (none)
Tags (none)




09-12-2018 12:04 PM
The Creator
Two opposing votes seem to indicate that the reporter might be wrong. I do not trust my English skills enough to judge this.

Opinions please :-) Factual ones preferred ;-)

09-12-2018 04:26 PM
Ancient Member
For ongoing characters I think djbrianuk is correct. As the character's vanquishing (or not vanquishing) of monsters is something that's continuing in the present, use of the present perfect (have not managed) is appropriate. Personally, I would omit the "yet" from his proposed statement, but it seems correct either way. The message when you have killed monsters actually has the same issue: for ongoing characters it should be "[N] monster(s) have/has perished under your attacks" rather than "[N] monster(s) perished under your attacks".

Note that the current messages actually are correct for dead/victorious characters, as they are finished with killing monsters.

09-13-2018 02:02 AM
Member
You used past tense, which is correct if the question is, "Did I kill anything?" it works fine. Present perfect tense is correct for ongoing action as Grond says, and may be more correct. Either way works, and works for me and I like the international feel. "Perfect" English is not necessary or desireable in Ancardia I think.

09-16-2018 09:22 AM
Junior Member
I still think I'm right, but this a pretty minor thing so I'm not fussed as to which way it goes. Technically following my criteria, the actual kill list once you've killed something is also incorrect, viz:

2 monsters perished under your attacks.

The following monsters were vanquished:
2 goblins

Should be

2 monsters have perished under your attacks (so far).

The following monsters have been vanquished:
2 goblins

But as I say this is very minor, hence me ranking it as lowest priority.

+ Reply