Crash on item dropping - ADOM & Ultimate ADOM Forums

Issue Tools
- View Changes

Crash on item dropping

05-21-2014 03:28 PM

Soirana

Ancient Member

Number of reported issues by Soirana: 41

Crash on item dropping

p23 on server - while dropping some stuff in shop - game crashed with saving. While on server game refuses to load to unvalid highscore[Fatal error "can't read highscores completely"], while recopied at my PC on laoding generates window of adom message with "Adom version 1.2.0 provides only 47 of requested 2670 spells."

Guess I can find error dump on server if needed.

Issue Details

Issue Number 2996

Issue Type Bug

Project ADOM (Ancient Domains Of Mystery)

Category ADOM Server (ancardia.com)

Status Unconfirmed

Priority 7

Affected Version ADOM 1.2.0 pre 23

Fixed Version (none)

Milestone (none)

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

05-21-2014 06:35 PM

Alucard

Senior Member

Around the same time (timestamp is US/EDT):

Code:

10:22:05 <     Jouni> "Eldim, the human merchant, was killed by .~L  ^Xx~L  , the female dark orc 
                      opening a booby-trapped door."
10:22:09 <     Jouni> hmm...
10:22:33 <     Jouni> as far as I know, that dark orc was not named at all
10:22:57 <     Jouni> maybe game though it was named, and thus read some random memory
10:24:53 <     Jouni> ok...
10:24:55 <     Jouni> Fatal error: "JSON: invalid UTF8 char."
10:28:14 <     Jouni> someone may want to check this - Fatal error: "Can't read highscores 
                      completely."
10:28:28 <     Jouni> maybe that last death of mine corrupted the hiscore file or something?
10:29:33 <     Jouni> at least I can't start adom right now because of that, so...

Broken HISCORE is here (live version on server was restored from backup)
On the servers versions 21, 22, and 23 share the same high score file. But Jouni was also playing 1.2.0p23. Jouni does not have tty recording enabled. Soirana does, so I'll check the replays for more information.
Soirana's adom.err is copied here (soirana-201405211727.adom.err, time zone is CEST) (this is probably just the one due to the invalid HISCORE)

05-21-2014 06:53 PM

Alucard

Senior Member

Soirana's crash can be reviewed by watching

Code:

soirana - ttyrec-Wed-May-21-15:31:25-2014.gz

But the output at the time of the crash was

Code:

NOTICE: backup .svg (more)
*** buffer overflow detected ***: /var/lib/adom/bin/adom-120p23-bin terminated
======= Backtrace: =========
/lib/i386-linux-gnu/libc.so.6(__fortify_fail+0x45)[0xb7633eb5]
/lib/i386-linux-gnu/libc.so.6(+0x103c8a)[0xb7632c8a]
/lib/i386-linux-gnu/libc.so.6(+0x102fbd)[0xb7631fbd]
/var/lib/adom/bin/adom-sage-0.9.21.so(_ZN17StateCmdProcessor8waddnstrEP7_win_stP
Kci+0x145)[0xb770e845]
/var/lib/adom/bin/adom-sage-0.9.21.so(waddnstr+0x71)[0xb7711e91]
/var/lib/adom/bin/adom-120p23-bin[0x8135866]
/var/lib/adom/bin/adom-120p23-bin[0x804d249]
/var/lib/adom/bin/adom-120p23-bin[0x8071c8b]
/var/lib/adom/bin/adom-120p23-bin[0x808ef3a]
/var/lib/adom/bin/adom-120p23-bin[0x817ab94]
/lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0xb75484d3]

Then a memory map, then the character information sheet (@) then

Code:

*** CRITICAL INTERNAL ERROR:
*** Signal 6 was raised.

adom-120p23-bin is the ADOM binary where the only modification is to change both mentions of adom_ds.xyz. But it looks like the crash could actually be caused by ADOM Sage's autosaver ("NOTICE: backup .svg").

05-21-2014 07:57 PM

Administrator

Code:

"Eldim, the human merchant, was killed by .~L  ^Xx~L  , the female dark orc opening a booby-trapped door."

This looks like the monster was killed by the explosion from the trapped door and a bad memory pointer was used to display the death cause.
The illegal characters written to the highscore made it unreadable. :(

05-21-2014 09:16 PM

Alucard

Senior Member

so I think we have two issues here, one a crash and two a bad cause of death corrupting HISCORE?

05-22-2014 04:10 AM

Soirana

Ancient Member

Originally Posted by Alucard

so I think we have two issues here, one a crash and two a bad cause of death corrupting HISCORE?

Don't know game restored back in shop on server so might be just highscore.

05-22-2014 03:46 PM

Alucard

Senior Member

But you still crashed with signal 6 (though this might not be ADOM's fault). The backup & restore is also not in vanilla ADOM. Are you saying the save was restored to the same turn as it crashed (or one previous) or 1000 turns ago?

05-22-2014 04:46 PM

Soirana

Ancient Member

Originally Posted by Alucard

Looked like very much one turn before crash, I think it might not loaded on home PC due to cross platform thing. Although highscore should not crash ongoing game...

05-22-2014 06:38 PM

Administrator

Originally Posted by Alucard

so I think we have two issues here, one a crash and two a bad cause of death corrupting HISCORE?

Yes, the second one has been fixed. I'm not sure about the first one... might be a SAGE problem, might be an ADOM bug.

+ Reply

Issue Tools